Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden xss security fix #527

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Harden xss security fix #527

merged 4 commits into from
Dec 18, 2024

Conversation

klemens-st
Copy link
Collaborator

@picandocodigo I realised the fix from #526 works well when someone uses excerpt_tag=script but if someone tries excerpt_tag="s(cript" the fix is ineffective, because to_html receives this value, escapes it with tag_escape so in the end it becomes script.

This small change prevents that.

Copy link
Owner

@picandocodigo picandocodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just working on adding more stuff to this same code! I'll add the commit to your branch.

Do we need to install svn manually on the GitHub Action?

@klemens-st
Copy link
Collaborator Author

Do we need to install svn manually on the GitHub Action?

Yes we do. I've just fixed it 😄

@klemens-st
Copy link
Collaborator Author

I've also just force pushed master to fix my commit message typo, sorry

@picandocodigo
Copy link
Owner

Thanks! Hopefully this will be the last fix for script 😅
I'll add the readme changes to this branch and if everything looks good on your side too we can tag 0.90.3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's great

@klemens-st
Copy link
Collaborator Author

Looks good, I'm almost sure there's no way to squeeze in script now 😆

@picandocodigo picandocodigo merged commit 70a4511 into master Dec 18, 2024
2 checks passed
@klemens-st
Copy link
Collaborator Author

Oh, I forgot to fix the deploy action so it failed, I'll fix it now.

@klemens-st
Copy link
Collaborator Author

It should be good now

@klemens-st
Copy link
Collaborator Author

Sorry again for the mess 😢 I've now fixed the deploy workflow and deleted the 0.90.3 tag so you can make the release again

@picandocodigo
Copy link
Owner

Haha, no worries! Thanks for the fix! I just pushed the tag again 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants