-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden xss security fix #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just working on adding more stuff to this same code! I'll add the commit to your branch.
Do we need to install svn
manually on the GitHub Action?
Yes we do. I've just fixed it 😄 |
I've also just force pushed master to fix my commit message typo, sorry |
Thanks! Hopefully this will be the last fix for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's great
Looks good, I'm almost sure there's no way to squeeze in |
Oh, I forgot to fix the deploy action so it failed, I'll fix it now. |
It should be good now |
Sorry again for the mess 😢 I've now fixed the deploy workflow and deleted the 0.90.3 tag so you can make the release again |
Haha, no worries! Thanks for the fix! I just pushed the tag again 👀 |
@picandocodigo I realised the fix from #526 works well when someone uses
excerpt_tag=script
but if someone triesexcerpt_tag="s(cript"
the fix is ineffective, becauseto_html
receives this value, escapes it withtag_escape
so in the end it becomesscript
.This small change prevents that.