Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-detect the trigger channel based on retrieved channel names #306
Auto-detect the trigger channel based on retrieved channel names #306
Changes from 53 commits
62ec35e
04bd62d
c30ac75
bf37e1f
23bf7f4
e43b51a
a4dff32
c400d23
bee4c71
fd115b9
0529d79
2b75fd4
c31a227
cf839f9
03cde91
16629c5
f0d2212
37b604a
a0e8c02
4ec2d10
28b0a25
59317b5
564eeea
5f99e95
77c46b8
89d27db
2cdda8a
cd27501
797e89c
00cf91b
b39bdde
3ce559c
ae3256a
aa66db2
b03a074
6233068
c8d7a63
c9457f3
169b3ae
3d6885c
fc603a4
bbdbb53
6389ca3
7dfe632
ed6f296
ca3fe59
fb28580
a969cb4
2beb6a1
320b5c8
a6bda02
b652a3b
b5fdba6
96af657
5bd6a33
a390bd6
71225f5
381f151
ae9d86f
c5a9285
7fe9e78
d305f4d
99b6b3f
a001a00
408c63d
7479635
d8169be
82f2175
ce4e813
504dca4
cef1363
1511054
a187f06
52fa097
7e79130
2046244
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get this point, but considering that:
I wouldn't output this warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't make any damage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, warnings mean that something peculiar is happening. At least I would consider downgrading this message to an
info
level.