Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Golang artifact repository documentation #253

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Dec 17, 2024


While I have tested this by locally denying packages, I was not able to get policies working with the Golang ecosystem. While that shouldn't change anything about this documentation, I can not positively confirm the ecosystem actually works in staging.

Closes #250

@cd-work cd-work self-assigned this Dec 17, 2024
@cd-work cd-work requested a review from a team as a code owner December 17, 2024 23:37
@maxrake maxrake linked an issue Dec 17, 2024 that may be closed by this pull request
maxrake
maxrake previously approved these changes Dec 19, 2024
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation LGTM...confirmed with a local checkout and build. The GOPROXY method was not tested as part of this review. Merging this PR to main should be coordinated with a release of the feature from STAGING to PROD.

@maxrake
Copy link
Contributor

maxrake commented Dec 19, 2024

I have now tried to test the Golang artifact registry feature in STAGING. I also was unable to get it to work as expected. We should figure this out offline before merging this documentation and feature to PROD.

Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature was tested locally and works as expected...for a package installed with and without a specific version. LGTM.

Copy link
Contributor Author

@cd-work cd-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to wait until go is deployed to prod.

@@ -17,6 +17,7 @@ Phylum registry URLs under which they are hosted:
| Ecosystem | Phylum Registry URL |
| --------- | --------------------------------------- |
| Cargo | <https://cargo.phylum.io/> |
| Golang | <https://golang.phylum.io> |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a conversation to block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Golang firewall documentation
2 participants