Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update policy documentation #194

Merged
merged 18 commits into from
Aug 7, 2024
Merged

docs: Update policy documentation #194

merged 18 commits into from
Aug 7, 2024

Conversation

furi0us333
Copy link
Contributor

  • Brought policy to the top level of the side nav as it seems like a prominent feature at this point
  • The previous documentation was focused on developing custom policies, so I consolidated that
  • I created a page for usage and a page for management of policies

@furi0us333 furi0us333 self-assigned this Aug 7, 2024
@furi0us333 furi0us333 requested a review from a team as a code owner August 7, 2024 20:13
@furi0us333
Copy link
Contributor Author

Please make sure I didn't miss anything. If this looks good enough, I think we can just close #187.

@janasheehan
Copy link
Contributor

janasheehan commented Aug 7, 2024 •
edited
Loading

overall, lgm - short and to the point

janasheehan
janasheehan previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@janasheehan janasheehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can deal with the ignore part later

maxrake
maxrake requested changes Aug 7, 2024
View reviewed changes
docs/knowledge_base/policy_development.md Outdated Show resolved Hide resolved
docs/knowledge_base/policy_development.md Outdated Show resolved Hide resolved
docs/knowledge_base/policy_development.md Outdated Show resolved Hide resolved
docs/knowledge_base/policy.md Outdated Show resolved Hide resolved
docs/knowledge_base/policy.md Outdated Show resolved Hide resolved
docs/knowledge_base/policy_usage.md Show resolved Hide resolved
docs/knowledge_base/policy_usage.md Show resolved Hide resolved
docs/knowledge_base/policy_usage.md Show resolved Hide resolved
docs/knowledge_base/policy_management.md Outdated Show resolved Hide resolved
docs/knowledge_base/policy_development.md Outdated Show resolved Hide resolved
@furi0us333 furi0us333 requested a review from maxrake August 7, 2024 23:18
maxrake
maxrake approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@furi0us333 furi0us333 merged commit cd07331 into main Aug 7, 2024
2 checks passed
@furi0us333 furi0us333 deleted the brad/policy branch August 7, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-phylum matt-phylum matt-phylum left review comments

@janasheehan janasheehan janasheehan left review comments

@maxrake maxrake maxrake approved these changes

Assignees

@furi0us333 furi0us333

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@furi0us333 @janasheehan @maxrake @matt-phylum