Use zip archives for phylum update
#225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrake
previously approved these changes
Apr 6, 2022
There was a problem hiding this comment.
I reviewed all the files. I don't know Rust well enough to claim that those files are good...but they appear to be good.
Trying the build artifacts resulted in no big issues found. I couldn’t try updating to the latest non-prerelease b/c that is still 1.2.0, which has the old artifact name/scheme...and the failure experienced there is expected. Updating to a prerelease version worked.
It would be nice to have others who are more familiar with Rust complete the review...but I'm providing my approval now based on the fact that the changes are confirmed to do what they say, based on manual verification testing.
cd-work
requested changes
Apr 6, 2022
Co-authored-by: Christian Dürr <[email protected]>
cd-work
approved these changes
Apr 6, 2022
eeclfrei
pushed a commit
that referenced
this pull request
Apr 10, 2022
* Use zip file in `phylum update` * Allow `phylum update` without authentication * Explain update from 1.2.0 in docs Co-authored-by: Christian Dürr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement
phylum updateby downloading the appropriate zip file and runninginstall.shChecklist