-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CycloneDX SBOMs #1200
Conversation
994006d
to
0f85a2e
Compare
0f85a2e
to
ebcf307
Compare
Co-authored-by: Christian Dürr <[email protected]>
543d8a7
to
c3626f6
Compare
c3626f6
to
f787003
Compare
Can one be generated from a common/popular project and then included here? It appears the EDIT: Further investigation on that repo shows that they already have a collection of examples to demo all the features. There are v1.5 samples included in there. |
Thanks @maxrake, updated with those examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
300k lines of lockfiles seems a bit excessive to me. Do these files really bring 300k lines of benefit? I don't think we gain much by having excessively large lockfiles that just repeat the same thing over and over again and it would be really unfortunate to bloat up our repo through these.
Note these are currently our biggest lockfiles:
-rw-r--r-- 1 chris chris 3.7M May 2 14:56 spdx-2.3.spdx.json
-rw-r--r-- 1 chris chris 2.6M May 2 14:56 spdx-2.2.spdx
-rw-r--r-- 1 chris chris 1.7M Oct 13 2022 workspace-effective-pom.xml
-rw-r--r-- 1 chris chris 228K Feb 24 19:52 go.sum
-rw-r--r-- 1 chris chris 132K Jan 20 2023 Cargo_v3.lock
Where the 3.7M spdx lockfile is ~100k lines. This is a significant amount of disk space especially if anything ever changes about them (thus effectively doubling their size in the git history), and this can definitely impact git clone
speed if it gets worse.
This patch changes the fixture directory size from 8.7M to 20M, more than doubling its size.
Add support for parsing CycloneDX SBOMs.
Documentation on
v1.5
specshttps://cyclonedx.org/docs/1.5/json/
https://cyclonedx.org/docs/1.5/xml/
Added test files for
v1.3
,v1.2
andv1.5
.Note:
optional
dependencies are skipped for now. @louislang and @furi0us333 suggested adding a flag to include those does when specified by the user.Closes #1188
Checklist
closes #<issueNum>
in description above)?