Fix symlink handling with Linux sandbox #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where dangling symbolic links would cause errors while locking down the sandbox since the `mount` syscall is not able to resolve the link. To ensure symlinks are mapped correctly, the Linux sandbox now maps every exception to its canonicalized path, granting access to the symlink's **TARGET**. Then if necessary the symlink pointing to this file is created to ensure access through the exception's original path.
kylewillmon
requested changes
Oct 26, 2023
kylewillmon
reviewed
Oct 26, 2023
kylewillmon
requested changes
Oct 30, 2023
cd-work
force-pushed
the
symlinks
branch
2 times, most recently
from
62297e1 to
a577afa
Compare
kylewillmon
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where dangling symbolic links would cause errors while locking down the sandbox since the
mountsyscall is not able to resolve the link.To ensure symlinks are mapped correctly, the Linux sandbox now maps every exception to its canonicalized path, granting access to the symlink's TARGET. Then if necessary the symlink pointing to this file is created to ensure access through the exception's original path.