Fix mounting special files #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd-work
commented
Oct 13, 2023
This fixes sandboxing exceptions for special files on Linux. Previously birdcage would explicitly panic.
kylewillmon
requested changes
Oct 16, 2023
| let tempdir = TempDir::new().unwrap(); | ||
| let symlink_str = tempdir.path().to_string_lossy() + "_tmpfile"; | ||
| let symlink_path = PathBuf::from(symlink_str.as_ref()); | ||
| unixfs::symlink(&tempdir, &symlink_path).unwrap(); |
There was a problem hiding this comment.
There might be some value in adding a broken symlink to one of these tests just to make sure that birdcage.lock() still succeeds. Although the symlink should remain broken inside the sandbox, so maybe that is pointless.
kylewillmon
approved these changes
Oct 16, 2023
kylewillmon
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.