Add Compatibility for Rack 3 (Rails > 7.1) #2507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rack3 is not compatible with Ruby 2.0.0p648, we need to maintain compat back to that version until EL7 is EOL. Can you update the deps to allow but not require Rack 3? |
Sure. I'll try 👍 |
|
What's the status on this one? At the moment it's not possible to deploy projects that use rails 7.1 |
3 tasks
|
Please update passenger gem with this patch. |
|
@GhaniyKie are you going to work on this further or should I take over? |
|
Yes. You can. 😄
…________________________________
Dari: Camden Narzt ***@***.***>
Dikirim: Rabu, 27 Maret 2024 00.03
Kepada: phusion/passenger ***@***.***>
Cc: Abdul Hakim Ghaniy ***@***.***>; Mention ***@***.***>
Subjek: Re: [phusion/passenger] Add Compatibility for Rack 3 (Rails > 7.1) (PR #2507)
@GhaniyKie<https://github.com/GhaniyKie> are you going to work on this further or should I take over?
—
Reply to this email directly, view it on GitHub<#2507 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKLYM3XLT7T55BLTOXHQ63DY2GS6BAVCNFSM6AAAAAA64PNAD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQHE4TONZWGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Any rough timeline for completion would be useful. However, I understand that is probably not possible. Appreciate the work done here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for Ruby Application using Rack 3 (e.g: Rails > 7.1) [Issues #2508]
This PR fix
Rack::Handler is deprecated and replaced by Rackup::Handlerdeprecation warning,Calling Rackup::Handler.register with a string is deprecated, use the class/module itself, anduninitialized constant Rackup::Handler::Rack (NameError)errors that i face.