Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added nonce support #86

Merged
merged 6 commits into from
Jul 11, 2024
Merged

feat: Added nonce support #86

merged 6 commits into from
Jul 11, 2024

Conversation

Varpuspaavi
Copy link
Contributor

@Varpuspaavi Varpuspaavi commented Jul 9, 2024

Added support for nonce in the script we load. :strict_dynamic on script_src is needed since we can't replace the nonce placeholders on the server side.

Seems like it is possible to add style-src to the config.content_security_policy_nonce_directives but something might break when doing so. Generally everything seems OK though.

Screenshot 2024-07-09 at 15 51 47

@Varpuspaavi Varpuspaavi marked this pull request as ready for review July 9, 2024 14:12
@Varpuspaavi Varpuspaavi requested a review from a team as a code owner July 9, 2024 14:12
@Varpuspaavi Varpuspaavi merged commit e7df6f7 into master Jul 11, 2024
4 checks passed
@Varpuspaavi Varpuspaavi deleted the ice-nonce branch July 11, 2024 06:41
github-actions bot pushed a commit that referenced this pull request Jul 11, 2024
# [3.2.0](v3.1.1...v3.2.0) (2024-07-11)

### Features

* Added nonce support ([#86](#86)) ([e7df6f7](e7df6f7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants