feat: Add config option to ignore keys #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
commented
May 21, 2024
| @@ -9,6 +9,10 @@ | |||
| config.account_id = "<%= options[:account_id] %>" | |||
| config.datacenter = "eu" | |||
|
|
|||
| # Configure an array of key names that should not be handled | |||
| # by the In-Context-Editor. | |||
| # config.ignored_keys = ["number.*", "foo.bar"] | |||
There was a problem hiding this comment.
Commented out so it doesn't alter current behavior.
| @@ -1,3 +1,3 @@ | |||
| module PhraseApp | |||
| VERSION = "2.1.0" | |||
| VERSION = "3.1.0" | |||
There was a problem hiding this comment.
Seems like this isn't getting incremented during the release process.
| @@ -3,8 +3,6 @@ | |||
| module PhraseApp | |||
| module InContextEditor | |||
| class BackendService | |||
| attr_accessor :blacklisted_keys | |||
There was a problem hiding this comment.
Yet another attr_acessor that did nothing.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
# [3.1.0](v3.0.1...v3.1.0) (2024-06-14) ### Features * Add config option to ignore keys ([#82](#82)) ([657b9f3](657b9f3))
|
@Bilka2 Thank you for your contribution and sorry it again took some time to get to here 🙏 Really appreciate your contributions! |
|
Thank you very much for merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #80.
Add
config.ignored_keysto exclude keys from being handled by the ICE.Implementation is inspired by pre 2.0 versions of this gem, with simplified code.