Merge pull request #189 from phrase/cleanup-speedup

Speed up upload cleanup by increasing per_page keys
phrase · Nov 25, 2019 · 034e7fa · 034e7fa
2 parents 9a3ec4f + 291fb99
commit 034e7fa
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/.version b/.version
@@ -1 +1 @@
-1.16.0
+1.16.1
diff --git a/build/innosetup/phraseapp-client-386.iss b/build/innosetup/phraseapp-client-386.iss
@@ -7,7 +7,7 @@
 ; (To generate a new GUID, click Tools | Generate GUID inside the IDE.)
 AppId={{DC598D8E-8A9B-4CAD-AFD8-0324FDF4E0F1}
 AppName=PhraseApp Client
-AppVersion=1.16.0
+AppVersion=1.16.1
 AppPublisher=PhraseApp GmbH
 AppPublisherURL=https://phrase.com/cli
 AppSupportURL=https://phrase.com/cli

diff --git a/build/innosetup/phraseapp-client.iss b/build/innosetup/phraseapp-client.iss
@@ -7,7 +7,7 @@
 ; (To generate a new GUID, click Tools | Generate GUID inside the IDE.)
 AppId={{DC598D8E-8A9B-4CAD-AFD8-0324FDF4E0F1}
 AppName=PhraseApp Client
-AppVersion=1.16.0
+AppVersion=1.16.1
 AppPublisher=PhraseApp GmbH
 AppPublisherURL=https://phrase.com/cli
 AppSupportURL=https://phrase.com/cli

diff --git a/upload_cleanup.go b/upload_cleanup.go
@@ -28,11 +28,9 @@ func (cmd *UploadCleanupCommand) Run() error {
 func UploadCleanup(client *phraseapp.Client, cmd *UploadCleanupCommand) error {
 	q := "unmentioned_in_upload:" + cmd.ID
 	params := &phraseapp.KeysListParams{Q: &q}
-
-	var err error
 	page := 1
 
-	keys, err := client.KeysList(cmd.Config.DefaultProjectID, page, 25, params)
+	keys, err := client.KeysList(cmd.Config.DefaultProjectID, page, 100, params)
 	if err != nil {
 		return err
 	}
@@ -43,8 +41,8 @@ func UploadCleanup(client *phraseapp.Client, cmd *UploadCleanupCommand) error {
 	}
 
 	for len(keys) != 0 {
-		ids := make([]string, len(keys), len(keys))
-		names := make([]string, len(keys), len(keys))
+		ids := make([]string, len(keys))
+		names := make([]string, len(keys))
 		for i, key := range keys {
 			ids[i] = key.ID
 			names[i] = key.Name
@@ -79,7 +77,7 @@ func UploadCleanup(client *phraseapp.Client, cmd *UploadCleanupCommand) error {
 		fmt.Printf("%d key(s) successfully deleted.\n", affected.RecordsAffected)
 
 		page++
-		keys, _ = client.KeysList(cmd.Config.DefaultProjectID, page, 25, params)
+		keys, _ = client.KeysList(cmd.Config.DefaultProjectID, page, 100, params)
 	}
 
 	return nil