Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml to build the windows extensions #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

reeperbahnause
Copy link

@reeperbahnause reeperbahnause commented Aug 27, 2024

This commit modifies the ci.yml to build the windows extension for php version 8.2 and 8.3
Php version prior to 8.2 are not included because the extensions are available at the pecl.
Building the extension for php version 8.4 is not possible yet.
Thanks to @cmb69 who helped with a hint of how to load the mbstring extension using the --enable-test-ini argument.
#36

This commit modifies the ci.yml to build the windows extension for php version 8.2 and 8.3
Php version prior to 8.2 are not included because the extensions are available at the pecl.
Building the extension for php version 8.4 is not possible yet.
Thanks to @cmb69 who helped with a hint of how to load the `mbstring` extension using the
`--enable-test-ini` argument.
@cmb69
Copy link
Member

cmb69 commented Aug 27, 2024

Php version prior to 8.2 are not included because the extensions are available at the pecl.

There are also 8.2 and 8.3 builds on PECL. But the main point of having CI here is verification that the extension can be built, and that the tests are running. I suggest to enable 8.0 and 8.1 builds.

Building the extension for php version 8.4 is not possible yet.

It should be (unless there is an issue with mailparse itself, in which case it would be good to see what that is). You need to update setup-php-sdk to v9, and also to switch to windows-2022. That should do. (Building for 7.4 is also possible, but somewhat tricky, and having builds for 5 PHP versions is already quite something.)

Thanks to @cmb69 who helped with a hint of how to load the mbstring extension using the --enable-test-ini argument.

Yeah, that is a terrible hack, but for now it should do. The setup-php-sdk action should at least provide the build path (that's useful for other task too), and maybe more.

Anyhow, thanks for your work!

@cmb69 cmb69 mentioned this pull request Aug 27, 2024
add build for php-8.4
.github/workflows/ci.yml Outdated Show resolved Hide resolved
change windows version and add php 8.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants