Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

on notification ios does not work on cold start #2654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

on notification ios does not work on cold start #2654

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 12, 2018

Description

Reimplemented the cold start logic from an old version (the ~1.0.0.)
Maybe the code was lost during various merges.

  • Changed the Firebase import to allow correct code compile.

Related Issue

#2629

Motivation and Context

on('notification') handler now will be called also on cold start. (When app is inactive)

How Has This Been Tested?

Real project in production.

Screenshots (if appropriate):

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yeliu84
Copy link

yeliu84 commented Jul 15, 2020

Is there an ETA of merging this PR? I've been having this issue for a long time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants