This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Added Channel Group #2607
Open
OliverOng1995
wants to merge
25
commits into
phonegap:master
Choose a base branch
from
OliverOng1995:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added Channel Group #2607
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e279230
Update PushConstants.java
OliverOng1995 7409827
Update PushPlugin.java
OliverOng1995 5c6b906
Update push.js
OliverOng1995 c84a968
Added channel group
OliverOng1995 157ecc5
Update push.js
OliverOng1995 3fbcffa
With channel group
OliverOng1995 ad3cf96
Update API.md
OliverOng1995 9f93723
Update push.js
OliverOng1995 c986805
Update index.d.ts
OliverOng1995 97e046c
Update index.d.ts
OliverOng1995 82201b7
Added hasPermission and visibility
OliverOng1995 bc1c552
Ok
fredgalvao 5abe309
fredgalvo change
fredgalvao 27149d8
Update types/index.d.ts
fredgalvao 14a0f58
Update types/index.d.ts
fredgalvao 8bac264
Update index.d.ts
OliverOng1995 9510d9f
Update types/index.d.ts
fredgalvao 3feeaab
Update types/index.d.ts
fredgalvao fe9e7c0
Update types/index.d.ts
fredgalvao f3df474
Update types/index.d.ts
fredgalvao 8a61e7c
Update types/index.d.ts
fredgalvao 617892f
Update types/index.d.ts
fredgalvao 05f5553
Update types/index.d.ts
fredgalvao 891023a
Update types/index.d.ts
fredgalvao 8a4ca82
Update types/index.d.ts
fredgalvao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these notes to fix later? We don't have the
name
attribute yet, so we don't have an official doc to copy from, so it would make sense.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup based on a previous pull request