Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change snake_case auth URLs to kebab-case #5979

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

glhrmv
Copy link
Contributor

@glhrmv glhrmv commented Nov 19, 2024

Fixes #5917

Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If CI passes, please merge!

@josevalim
Copy link
Member

CI is failing but for other reasons. But this looks good to me!

@SteffenDE SteffenDE merged commit 394e501 into phoenixframework:main Nov 26, 2024
5 of 7 checks passed
@SteffenDE
Copy link
Contributor

Thank you! 🙌

@glhrmv glhrmv deleted the auth-urls-kebab-case branch November 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLs generated by phx.gen.auth should be in kebab-case and not snake_case
3 participants