Set gzip default based on code reloading in endpoint #5971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a `:success` kind for flash messages in the generator output and update relevant documentation. Success messages that previously used `:info` now use `:success`, ensuring they continue to appear in green with a "Success!" title. In certain cases (e.g. password reset), `:info` is retained to avoid disclosing too much information (such as the existence of an account). These messages now appear in blue with a "Please note" title. Rationale for those changes: - Differentiate informational messages from successful actions - Avoid confusion from informational messages styled in green, which can imply success - Ensure `:info` is used for neutral messages, and use `:success` to clearly indicate completed actions
Adjust the default for the gzip flag in the generated endpoint to take code reloading into account. Fixes phoenixframework#5960
|
Oops. Based off of a wrong branch :-) my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the default for the gzip flag in the generated endpoint to take
code reloading into account.
Fixes #5960