import only required function #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
approved these changes
Nov 9, 2024
yakov-cl
force-pushed
the
import-only-required-function
branch
from
427d840
to
2a7d13e
Compare
Gazler
reviewed
Nov 11, 2024
yakov-cl
force-pushed
the
import-only-required-function
branch
from
2a7d13e
to
9cf7a57
Compare
Based on hexdocs: https://hexdocs.pm/elixir/alias-require-and-import.html\#import it is recommended to only import the function you are using. This change proposes to just import `render_to_string` in the `error_html_test.exs` file
yakov-cl
force-pushed
the
import-only-required-function
branch
from
9cf7a57
to
b2d5e18
Compare
|
Thank you! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on hexdocs: https://hexdocs.pm/elixir/alias-require-and-import.html\#import it is recommended to only import the function you are using. This change proposes to just import
render_to_stringin theerror_html_test.exsfile