Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check_csrf option to socket transport options #5952

Merged
merged 17 commits into from
Oct 31, 2024
Merged

Add check_csrf option to socket transport options #5952

merged 17 commits into from
Oct 31, 2024

Commits on Oct 13, 2024

  1. Implement optionnal CSRF check

    @tanguilp
    tanguilp committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    50cdc6d View commit details
    Browse the repository at this point in the history

  2. Implement the check_csrf option

    @tanguilp
    tanguilp committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    492e489 View commit details
    Browse the repository at this point in the history

  3. Document check_csrf option in Phoenix.Endpoint

    @tanguilp
    tanguilp committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e845ac8 View commit details
    Browse the repository at this point in the history

  4. Add test for check_csrf option

    @tanguilp
    tanguilp committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    759eed4 View commit details
    Browse the repository at this point in the history

  5. Use boolean operator in condition

    @tanguilp
    tanguilp committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    467e378 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Add test that checks disabling both origin and CSRF checks raises

    @tanguilp
    tanguilp committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5f2bf63 View commit details
    Browse the repository at this point in the history

  2. Add check that one of origin and CSRF check is performed

    @tanguilp
    tanguilp committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    d80a535 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Update Phoenix.Socket.Transport.connect_info/4 doc 

    We take into account that it's no longer possible to have both CSRF
and origin checks disabled at the same time
    @tanguilp
    tanguilp committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f5b45bf View commit details
    Browse the repository at this point in the history

  2. Set the connect_option default options to [] 

    Co-authored-by: José Valim <[email protected]>
    @tanguilp @josevalim
    tanguilp and josevalim authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f9a8f29 View commit details
    Browse the repository at this point in the history

  3. Update Phoenix.Endpoint doc regarding the check_csrf opt 

    Cannot be disabled with `check_origin` disabled as well
    @tanguilp
    tanguilp committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0f3fdab View commit details
    Browse the repository at this point in the history

  4. Fix doc indentation in endpoint 

    Co-authored-by: José Valim <[email protected]>
    @tanguilp @josevalim
    tanguilp and josevalim authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5b2ba48 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. Check prsence of CSRF or origin check when starting the transports

    @tanguilp
    tanguilp committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    d339626 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Fix typo in exception message 

    Co-authored-by: José Valim <[email protected]>
    @tanguilp @josevalim
    tanguilp and josevalim authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    0007b6c View commit details
    Browse the repository at this point in the history

  2. Use Keyword.get/3 instead of if construct 

    Co-authored-by: José Valim <[email protected]>
    @tanguilp @josevalim
    tanguilp and josevalim authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    a912c18 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Refactor check and add tests

    @tanguilp
    tanguilp committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    7018509 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Update lib/phoenix/endpoint/supervisor.ex

    @josevalim
    josevalim authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0e2c1cb View commit details
    Browse the repository at this point in the history

  2. Update lib/phoenix/endpoint.ex

    @josevalim
    josevalim authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6acae44 View commit details
    Browse the repository at this point in the history