Use aria-live="polite" for flash_groups #5920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This nicely notifies screen readers and such of changed content/alerts. See [aria-live](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-live) for more info.
|
I think for most cases "polite" seems like a reasonable choice. In any case, its part of CoreComponents, so if users desire they can easily alter the default. |
|
Thank you! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nicely notifies screen readers and such of changed content/alerts.
See aria-live for more info.
I've seen some folks use
assertiveinstead ofpolitefor the aria-live setting in a flash/toast context. I'm unsure if there is a defacto one to use in this case though. Open to feedback!