Stringify lists in the ChannelTest module #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing with channels, map keys are stringified to replicate what
would happen in the browser. This allows a test such as:
push(socket, "topic", %{foo: "bar"})
The ChannelTest module will modify this to reflect a real client,
resulting in the channel receiving:
%{"foo" => "bar"}
This commit also includes arrays, making the behaviour consistent when
pushing data containing an array.
josevalim
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing with channels, map keys are stringified to replicate what would happen in the browser. This allows a test such as:
The ChannelTest module will modify this to reflect a real client, resulting in the channel receiving:
This commit also includes arrays, making the behaviour consistent when pushing data containing an array.
This closes #5423