[Socket Draining] Dynamic socket drainer configuration

[studzien]

To configure the socket drainer, one must currently set it up during the compile time. I suggest adding an option to pass {M, F, A} to return the drainer configuration keyword list, just like the check_origin option. This would allow for runtime configuration of the drainer.

However, I could not find any tests related to this feature.

[studzien]

Hi @josevalim 👋
Since you worked on the socket draining, would you be interested in looking at this PR?
Thank you!

[josevalim]

Couldn't you configure it on config/runtime.exs with dynamic values?

[studzien]

The drainer can be configured at compile-time using socket in the endpoint. Is there a way to configure it dynamically? I couldn't find a way to do this, so I assumed that's why check_origin and connection_info.session can be configured via MFAs.

[josevalim]

You are right. I thought this was about the endpoint drainer, not the socket one. :)

[josevalim]

Can you please add a test?

[studzien]

Sure! I tried to cover all cases, including static config and :ignore, in test/phoenix/socket/socket_test.exs. However, I am uncertain if that is the most appropriate location.

[josevalim]

💚 💙 💜 💛 ❤️