This repository has been archived by the owner on Apr 26, 2021. It is now read-only.
Use Try Catch For PPAPI Flash Path Append #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phobal
reviewed
Jan 16, 2019
| app.commandLine.appendSwitch( | ||
| "ppapi-flash-path", | ||
| app.getPath("pepperFlashSystemPlugin") | ||
| ); | ||
| } catch (err) { | ||
| // Handling Non Flash Errors | ||
| } |
There was a problem hiding this comment.
对于 Windows 平台加载 flash 插件的情况比较复杂，有一个比较 hack 的方式就是将 Windows 系统里面的 flash.dll 文件 copy 到项目中来，这里 app.getPath(path) ,path 就指向存放 dll 的目录
There was a problem hiding this comment.
对，其实就是一个dll，但是这么做应该会有license问题？可以在catch里面做提示用户自行前往flash官网下载新版flash的逻辑？现在windows的QQ最新版就会这样，会提示跳转去flash官网下载flash，而不是内置，应该是QQ现在也是使用了webkit来做ui了，
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.