Makes the module compatible with Magento 1.9.4.3+ #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than two times by changing the if() condition
…tract method of the base abstract class and thus cannot be concrete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #33
This PR updates the module to take into account Magento's own implementation of the FixerIO integration.
The main model in this module was changed to be a rewrite of Magento's implementation (when this is present), and the extension configuration was changed to mirror Magento's. Basically, this module replaces Magento's implementation for versions 1.9.4.3 and above and provides an implementation that was not present for Magento versione below that one.
The only drawback that I can see is that the system config field for the api key was renamed from access_key to api_key. So if someone upgrades this module from an older version to one including this PR, he/she would have to re-enter the API key value in the configuration field, otherwise the module would not work.