Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: line jumps on cursor movement when word wrap is enabled #1971

Merged
merged 4 commits into from
Dec 7, 2024
Merged

fix: line jumps on cursor movement when word wrap is enabled #1971

merged 4 commits into from
Dec 7, 2024

Conversation

abose
Copy link
Member

@abose abose commented Dec 7, 2024

Fixes: https://www.reddit.com/r/brackets/comments/1h8dnb3/word_wrap_movement/

This change addresses the issue of enabling continuous matching tag highlighting in CodeMirror. Initially, we achieved this by changing the span style from inline (default) to inline-block. While this allowed for continuous highlighting, it inadvertently broke word wrapping, which does not function correctly in an inline-block context.

To resolve this, we transitioned to a border-based implementation for the matching tag highlight. This approach preserves the continuous highlighting functionality without impacting word wrapping behavior.

Copy link

sonarcloud bot commented Dec 7, 2024

@abose abose merged commit ec7064d into main Dec 7, 2024
17 of 18 checks passed
@abose abose deleted the x branch December 7, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant