Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant import statements, and fix broken links #1875

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Remove redundant import statements, and fix broken links #1875

merged 2 commits into from
Oct 2, 2024

Conversation

devvaannsh
Copy link
Contributor

This PR makes the following changes :

  1. In indexingWorker.js and workerComm.js, the jsdoc has import statements, so removing them as the script automatically adds import statements.
  2. The build failed issue on docs site was because of the link inside indexingWorker file. The link was supposed to lead to workerComm file, but was pointing to an invalid path.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@abose abose merged commit d0551fd into phcode-dev:main Oct 2, 2024
17 checks passed
@abose
Copy link
Member

abose commented Oct 2, 2024

LGTM. Merging.
Thanks for contributing @devvaannsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devvaannsh @abose