Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: click binoculor icon/locate in file tree for non project files now opens file in os explorer #1290

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

abose
Copy link
Member

@abose abose commented Jan 12, 2024

Earlier, for external project files, this used to do nothing, and the user would be a bit confused on where the file is located or if they actually clicked on the icon as nothing happened. Address the UX.

@phoenixide
Copy link
Member

Thank You for making this pull request.

1 similar comment
@phoenixide
Copy link
Member

Thank You for making this pull request.

@abose abose merged commit 8bdb5a6 into main Jan 12, 2024
14 of 15 checks passed
@abose abose deleted the loc branch January 12, 2024 09:08
@phoenixide
Copy link
Member

Thank You for making this pull request.

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants