fix: live preview should allow tab popout on window.open or href click #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank You for making this pull request. |
17 tasks
Thank You for making this pull request. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since its an HTML development tool, it will confuse users if we disable window.open/ anchor tag hrefs not opening up new windows. So we enable that.
The security posture wont change due to this as 1, since the iframe is sandboxed, the popout that escaped the sandox will no loger be able to communicate with phcode, and hence isolated.
Another thing to note is that, for virtual serving urls, the popout will result in a 404 as the virtual server is sandboxed within a tab/phcode. But this is the case even before this change. Normal click-navigations will not be affected, just
open link in new tabworkflows with virtual server target urls will fail.