Shortcut refactor and fix UX issues with keyboard shortcuts #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
…/Right, fix mac test fails
Thank You for making this pull request. |
Thank You for making this pull request. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alt-Left arrowfor nav back andAlt-Right arrowto nav forwardCtrl-Shift-0- show in file treeCtrl-N- desktop only andCtrl-1(all platforms)Ctrl-3(all platforms)Ctrl-Shift-N- desktop only. In browser, use can doctrl-Tand type phcode.dev using browser shortcuts itself. So we dont make a browser shortcut for this.Ctrl-W- desktop only andCtrl-`(all platforms)Ctrl-Oin desktop only as browser doesnt support open file featureCtrl-Obrowser only, open folder has no shortcut in desktop builds for now as its only ever used when the user opens a project once in a while.Alt-Shift-Leftinstead ofCtrl-Alt-[Alt-Shift-Rightinstead ofCtrl-Alt-]Ctrl-Alt-[instead ofAlt-1in win andCmd-1in macCtrl-Alt-]instead ofAlt-Shift-1in win/linux andCmd-Shift-1in macTest suite enhancements
This pull request introduces a significant enhancement to our browser-based test suites by adding a 'Simulate OS' dropdown menu. This feature is designed to streamline the process of debugging and running tests across different operating systems without the need to physically switch or boot into another machine.
The feature is currently limited to browser tests and is not implemented in desktop builds. This is due to potential compatibility issues with the Tauri framework, where simulating different OS environments in desktop builds could lead to unpredictable behaviors or break the functionality.
Remaining shortcut related fixes for native builds beta is covered in: #1259