Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zoom in and zoom out working in desktop builds #1252

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat: zoom in and zoom out working in desktop builds #1252

merged 1 commit into from
Dec 28, 2023

Conversation

abose
Copy link
Member

@abose abose commented Dec 27, 2023

native builds

zoom between 50% and 200% in native builds.
image
image

web builds

Use browser controlled zoom, so we dont show zoom % as its displayed by browser in url bar.
image

In browser, only zoom with shortcuts ctrl+/-. . Click on menu item will show up a dialog unlike in tauri where zoom is possible by clicking menu item.
image

Related:

  1. https://github.com/phcode-dev/phoenix-desktop/pull/162/files
  2. Zoom in and out not working in tauri #1168

@phoenixide
Copy link
Member

Thank You for making this pull request.

Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@abose abose merged commit 5f07bed into main Dec 28, 2023
17 checks passed
@abose abose deleted the zoom branch December 28, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants