Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: privacy aware node bugsnag crash reporting #1248

Merged
merged 3 commits into from
Dec 20, 2023
Merged

chore: privacy aware node bugsnag crash reporting #1248

merged 3 commits into from
Dec 20, 2023

Conversation

abose
Copy link
Member

@abose abose commented Dec 20, 2023 •
edited
Loading

  • Catch uncaught exceptions and erros in node and log in bugsnag, strip all user file system paths from stack for privacy.
  • fix: bind phNode api server to localhost only to prevent windows firewall dialog

@phoenixide
Copy link
Member

Thank You for making this pull request.

@abose abose mentioned this pull request Dec 20, 2023
Closed
3 tasks
@phoenixide
Copy link
Member

Thank You for making this pull request.

@phoenixide
Copy link
Member

Thank You for making this pull request.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@abose abose merged commit 8e2cf9e into main Dec 20, 2023
17 checks passed
@abose abose deleted the nod branch December 20, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abose @phoenixide