Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove drag and drop to install extension workflow #1154

Merged
merged 3 commits into from
Oct 27, 2023
Merged

chore: remove drag and drop to install extension workflow #1154

merged 3 commits into from
Oct 27, 2023

Conversation

abose
Copy link
Member

@abose abose commented Oct 27, 2023

Reason for Removal

The drag-and-drop functionality for extension installation has been removed due to its limited usage and poor user experience. Previously, users had to navigate to the extension manager and drop a zip file into a specific area to install extensions, a process that was not very intuitive.
Removed the code as it was too much code doing too little ux things, and it was broken anyway.

Proposed Alternatives for Future

  1. Adopting a method similar to VSCode, we will change the extension file type from .zip to .phx to indicate it's an extension for our editor.
  2. Instead of requiring a specific drop location, users will be able to drag and drop the extension file anywhere within the editor. Doing so will initiate the extension installation process.
  3. Additionally, double-clicking the extension file from the native file explorer/finder will launch the editor and start the extension installation workflow.

other changes

Tauri caches assets. so when we are developing an extension using load this project as extension workflow, upon a quick reload with the f5 key press without restarting the app, the stale cached extension code is served. So, now, we add a random prefix to the load path so that the cache is not hit on subsequent extension reloads for development.

Screenshot

before

image

after

image

@phoenixide
Copy link
Member

Thank You for making this pull request.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phoenixide
Copy link
Member

Thank You for making this pull request.

@abose abose merged commit aa2301b into main Oct 27, 2023
15 checks passed
@abose abose deleted the ext branch October 27, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants