feat: enable live preview tests in chromium in GitHub Actions #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank You for making this pull request. |
Thank You for making this pull request. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unfortunateley, we can run the live preview integ tests only in chrome
In Firefox playwright setup, sandbox prevents service worker access from nested iframes. So the virtual server itself will
not be loaded in firefox tests in playwright.
Do note that this limit is only observed when running tests in firefox under playwright. If you run the live preview integ tests
directly in firefox, the tests run just fine.
In tauri, we use node server, so this limitation doesn't apply in tauri test runners. This restriction is
only there for firefox tests in playwright.