Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nsis #180

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Nsis #180

merged 5 commits into from
Jan 18, 2024

Conversation

charlypa
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix - fixes issues- give issue github url/details here.
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Screenshots or Gifs of the change

  1. Any visual or workflow changes must come with a gif or screenshot.
  2. Gif screen recordings help more if present. You can use one of the below free screen recorders:
    1. windows gif recorder- https://www.screentogif.com/
    2. mac gif recorder- https://apps.apple.com/au/app/giphy-capture-the-gif-maker/id668208984?mt=12
    3. linux gif recorder- https://github.com/phw/peek

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Tests done

  • Describe unit tests done
  • Describe integration tests done
  • Describe manual tests done

Checklist

  • When resolving issues, reference those issue URLs in description.
  • Propose a changelog if this pull request has any customer facing impact.
  • I have added a convincing reason for adding this feature, if necessary.

Other information

pull request guidelines:

  • It's OK to have multiple small commits as you work on the PR - we will let GitHub automatically squash it before merging.
  • If adding new feature:, Provide convincing reason to add this feature. Ideally you should open a suggestion issue first and have it greenlighted before working on it.
  • If fixing a bug:Provide detailed description of the bug in the PR, or link to an issue that does.
  • Provide screenshots or gifs of the changes whenever possible.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@charlypa charlypa merged commit a0002ae into main Jan 18, 2024
4 checks passed
@charlypa charlypa deleted the nsis branch January 18, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant