This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Don't set unique_session_id if devise.skip_session_limitable is set #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ | |||
| # and on authentication. Retrieving the user from session (:fetch) does | |||
| # not trigger it. | |||
| Warden::Manager.after_set_user :except => :fetch do |record, warden, options| | |||
| if record.respond_to?(:update_unique_session_id!) && warden.authenticated?(options[:scope]) | |||
| if record.respond_to?(:update_unique_session_id!) && warden.authenticated?(options[:scope]) && !warden.request.env['devise.skip_session_limitable'] && !warden.request.session.key?('impersonator_id') | |||
There was a problem hiding this comment.
That's quite a conditional. Can you refactor into smaller, meaningfully-named methods?
|
Could you write some tests to support your work? This project really needs 'em! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to disable the setting of the unique_session_id. This adds the skip_session_limitable option to set as well as fetch