Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Replace Fixnum references #232

Closed
wants to merge 2 commits into from
Closed

Conversation

3zcurdia
Copy link

It replaces references Fixnum references from ruby 2.4.
It closes #231

@3zcurdia 3zcurdia force-pushed the replace-fixnum branch 5 times, most recently from c48cdc7 to 1620a72 Compare December 19, 2017 18:11
@3zcurdia 3zcurdia force-pushed the replace-fixnum branch 2 times, most recently from d550ac0 to b0c62ae Compare December 19, 2017 18:52
@Gasparila
Copy link

@alexdreher any way we can get this merged?

@vimutter
Copy link

@3zcurdia I think you need to update Gemfile for 2.4. Do you need help with that?

@erolms
Copy link

erolms commented Apr 12, 2018

Folks, when can we get this commit merged into master?

@Gasparila
Copy link

Until this is merged, we "fixed" the deprecation warnings by adding Devise::Models::PasswordArchivable.const_set("Fixnum", Integer) to the devise initializer file

@erolms
Copy link

erolms commented Apr 13, 2018

In my case I had to add Devise::Models::PasswordExpirable.const_set("Fixnum", Integer) too. Working like a charm, thanks!

@tibbon
Copy link

tibbon commented Jul 26, 2018

What's the status of this?

@3zcurdia
Copy link
Author

closing this PR in favor of #238

@3zcurdia 3zcurdia closed this Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixnum is deprecated as of Ruby 2.4.0
5 participants