This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Replace low-priority operators #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tors. Leaving out parens is all well and good, but when it causes semantic problems it's time to put them on there.
|
This looks great. Is there anything needed to merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator inconsistencies have always bugged me. High-priority (
&&,||,!) and low-priority (and,or,not) operators are used interchangably throughout the code, and it's caused bugs in the past. This is an attempt to standardize them to the high-priority operators so there's less chance of future mishaps.I also found a couple of operators which were missing altogether, so I added those in.