Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow task-specific Composer arguments and apply defaults #320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arithmetric
Copy link
Collaborator

This fixes #319.

Changes:

  • Initializes grunt-composer after configuration to enable multi task mode and task-specific configuration.
  • Updates default tasks for multi task mode.

At this point, this has a potential breaking change, since the Grunt commands composer:install and composer:update no longer work and must be changed to composer:install:install and composer:update:update.

Copy link
Contributor

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doubling up of the task target looks really strange, is the idea that the first instance tells composer which command to run and the second which configuration to use?

@grayside
Copy link
Contributor

This is surfacing bugs in the package command for Drupal 8, which we already know is badly broken. Going to play with this some more but will probably merge as a precursor to fixing package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default and custom Composer arguments not applied
2 participants