Skip to content

Commit

Permalink
Remove unnecessary method
Browse files Browse the repository at this point in the history
  • Loading branch information
Hernán Morales Durand committed Nov 25, 2024
1 parent 2238ce0 commit ab1b5d3
Showing 1 changed file with 0 additions and 72 deletions.
72 changes: 0 additions & 72 deletions src/NewTools-SettingsBrowser-Tests/StSettingsTrackerTest.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,6 @@ Class {
#package : 'NewTools-SettingsBrowser-Tests'
}

{ #category : 'private' }
StSettingsTrackerTest >> newMockSetting: aMockSetting asSTON: stream [

^ (STONWriter on: (ZnCharacterWriteStream on: stream))
prettyPrint: true;
newLine: OSPlatform current lineEnding;
nextPut: aMockSetting

]

{ #category : 'private' }
StSettingsTrackerTest >> newMockSettingAsSTONString: aMockSetting [

^ (ByteArray streamContents: [ :stream |
self
newMockSetting: aMockSetting
asSTON: stream ]) asString

]

{ #category : 'private' }
StSettingsTrackerTest >> newMockSettingDeclaration: id [

Expand All @@ -53,11 +33,6 @@ StSettingsTrackerTest >> newSettingsTracker [
StSettingsTrackerTest >> setUp [

super setUp.

self flag: #ToDo.
"This is wrong but CI is failing without it (needs more work)"
StSettingsTracker reset.

tracker := StSettingsTracker new.

]
Expand Down Expand Up @@ -85,20 +60,6 @@ StSettingsTrackerTest >> tearDown [
super tearDown
]

{ #category : 'tests' }
StSettingsTrackerTest >> testBooleanSettingTracked [
"Check if the updated setting was tracked"

| settingItem numberOfUpdates |

self skip: 'For some reason it does not pass in CI but in the image does'.
numberOfUpdates := tracker sessionLog size.
settingItem := true asSettingPresenter: (self newMockSettingDeclaration: 1).
settingItem value: false.

"self assert: tracker sessionLog size equals: numberOfUpdates + 1"
]

{ #category : 'tests' }
StSettingsTrackerTest >> testBooleanSettingUpdated [
"Check if the updated setting was tracked"
Expand All @@ -116,23 +77,6 @@ StSettingsTrackerTest >> testBooleanSettingUpdated [

]

{ #category : 'tests' }
StSettingsTrackerTest >> testNumberSettingTracked [
"Check if the updated setting was tracked"

| settingItem numberOfUpdates |

numberOfUpdates := tracker sessionLog size.

settingItem := 10 asSettingPresenter: (self newMockSettingDeclaration: 2).
settingItem value: 20.
self submitPresenter: settingItem.

self assert: tracker sessionLog size equals: numberOfUpdates + 1.
settingItem delete.

]

{ #category : 'tests' }
StSettingsTrackerTest >> testNumberSettingUpdated [
"Check if the updated setting was tracked"
Expand All @@ -151,22 +95,6 @@ StSettingsTrackerTest >> testNumberSettingUpdated [

]

{ #category : 'tests' }
StSettingsTrackerTest >> testTextSettingTracked [
"Check if the updated setting was tracked"

| settingItem numberOfUpdates |

numberOfUpdates := tracker sessionLog size.

settingItem := 'Adios' asSettingPresenter: (self newMockSettingDeclaration: 3).
settingItem value: 'Hola'.
self submitPresenter: settingItem.

self assert: tracker sessionLog size equals: numberOfUpdates + 1.
settingItem delete.
]

{ #category : 'tests' }
StSettingsTrackerTest >> testTextSettingUpdated [
"Check if the updated setting was tracked"
Expand Down

0 comments on commit ab1b5d3

Please sign in to comment.