Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GlorpSQLite3 README.md link #152

Closed
wants to merge 1 commit into from

Conversation

labordep
Copy link

The link to SQLite3 in the readme redirects to a SQLite3 library that does not utilize Glorp. I believe the correct link is: https://github.com/PierceNg/glorp-sqlite3.

The link to SQLite3 in the readme redirects to a SQLite3 library that does not utilize Glorp. I believe the correct link is: https://github.com/PierceNg/glorp-sqlite3.
@gcotelli
Copy link
Member

The link is OK as it is. The referenced project includes an optional group with the Glorp-related code. It's also continuously tested See https://github.com/pharo-rdbms/glorp/blob/master/.smalltalkci/.SQLite3.ston

@gcotelli gcotelli closed this Jan 20, 2024
@labordep
Copy link
Author

Ok thanks.
I realize that something is missing in the project documentation.

The readme said "Use its Metacello snippet to load both Glorp and the driver in one go" and when I am on the page there is no script to "load both Glorp and the driver in one go" and no mention to Glorp!
It's not clear that we need to load a thing that isn't obvious to guess.

@gcotelli
Copy link
Member

gcotelli commented Jan 20, 2024 via email

@labordep
Copy link
Author

Please propose an update to the readme so it's more clear. The docs in the project are in need of some love.

On Sat, Jan 20, 2024, 09:57 Pierre Laborde @.> wrote: Ok thanks. I realize that something is missing in the project documentation. The readme said "Use its Metacello snippet to load both Glorp and the driver in one go" and when I am on the page there is no script to "load both Glorp and the driver in one go" and no mention to Glorp! It's not clear that we need to load a thing that isn't obvious to guess. — Reply to this email directly, view it on GitHub <#152 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQCK6ES6XBEE5WV7M32TDDYPO5MJAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4DONRYG4 . You are receiving this because you modified the open/close state.Message ID: @.>

You have right :)
I will propose an update if I succeed to load the sub-project with glorp >< see: pharo-rdbms/Pharo-SQLite3#108

@gcotelli
Copy link
Member

gcotelli commented Jan 20, 2024 via email

@labordep
Copy link
Author

Thanks I will complete my issue with this dicussion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants