Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monticello: Remove dead code #15351

Merged
merged 17 commits into from
Nov 14, 2023

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Nov 13, 2023

Here is a list of changes:

  • Remove unused topological sort of ancestors
  • Clean MCCacheRepository (2 unused vars and some methods and removed MCPackageCache with it)
  • Remove unused backport feature
  • Remove MCConfiguration with its reader, writer and browser because it seems really legacy and an ancestor to Metacello
  • Remove unused MCFilteredVersionSorter
  • Remove MCD format that seems to be a format to export diffs but this seems unused also
  • Remove unused version inspector
  • Remove MCSubDicrectoryRepository that seems unused
  • Merge some classes together (only one was used)
  • Remove MCVersionHistoryBrowser that seems unused

This one goes with this change: pharo-spec/NewTools#610

@jecisc
Copy link
Member Author

jecisc commented Nov 13, 2023

Lot of code is used only by Gofer.. We'll need to clean this one aswell

@MarcusDenker MarcusDenker merged commit ef9967f into pharo-project:Pharo12 Nov 14, 2023
1 check passed
@jecisc jecisc deleted the monticello/cleanings branch November 14, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants