Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gtsummary function for table 09 #245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattkorb
Copy link
Collaborator

@mattkorb mattkorb commented Dec 9, 2024

Pull Request

Closes #216

@mattkorb mattkorb linked an issue Dec 9, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Dec 9, 2024

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  -----------------
R/fda-fig_01.R         75       0  100.00%
R/fda-fig_02.R         75       0  100.00%
R/fda-fig_03.R        107       0  100.00%
R/fda-fig_14.R        115       0  100.00%
R/fda-table_02.R      166       0  100.00%
R/fda-table_03.R       35       0  100.00%
R/fda-table_04.R       63       0  100.00%
R/fda-table_05.R      157       3  98.09%   61, 124, 265
R/fda-table_06.R       76       0  100.00%
R/fda-table_07.R       35       0  100.00%
R/fda-table_08.R       46       0  100.00%
R/fda-table_09.R      376      11  97.07%   731, 748-757, 809
R/fda-table_10.R       26       0  100.00%
R/fda-table_11.R       92       0  100.00%
R/fda-table_12.R       84       0  100.00%
R/fda-table_13.R       20       0  100.00%
R/fda-table_14.R       27       0  100.00%
R/fda-table_15.R       32       0  100.00%
R/fda-table_16.R       32       0  100.00%
R/fda-table_17.R       32       0  100.00%
R/fda-table_18.R       32       0  100.00%
R/fda-table_20.R       71       0  100.00%
R/fda-table_21.R       78       0  100.00%
R/fda-table_22.R       77       0  100.00%
R/fda-table_32.R       94       0  100.00%
R/fda-table_33.R       95       0  100.00%
R/fda-table_34.R       41       0  100.00%
R/fda-table_35.R       23       0  100.00%
R/fda-table_36.R       30       0  100.00%
R/fda-table_38.R       39       0  100.00%
R/utils.R              28       0  100.00%
TOTAL                2279      14  99.39%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  -------
R/fda-table_09.R      +47     +11  -2.93%
TOTAL                 +47     +11  -0.48%

Results for commit: fa075db

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
fda-table_09 💔 $7.94$ $+3.04$ $+12$ $+2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
fda-table_09 💀 $0.38$ $-0.38$ Table_09_generation_works_with_custom_values
fda-table_09 👶 $+1.24$ Table_09_generation_works_with_gtsummary_with_custom_values
fda-table_09 👶 $+0.43$ Table_09_generation_works_with_risk_difference_column
fda-table_09 💀 $0.41$ $-0.41$ Table_09_gt_generation_works_with_risk_difference_column
fda-table_09 👶 $+0.40$ Table_09_rtables_generation_works_with_custom_values
fda-table_09 👶 $+0.34$ Table_09_rtables_generation_works_with_default_values

Results for commit 543b38b

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @mattkorb! I think the qmd files for the quarto pages needs to be updated with these changes. I'll review this again once those changes are up too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New ARD] ARD for table 09
2 participants