Supersede derive_var_bcvacritxfl() and update vignettes/templates that use it
#247
Open
1 of 2 tasks
Assignees
Comments
manciniedoardo
changed the title
derive_var_bcvacritxfl() and update vginettes/templates that use it
manciniedoardo
changed the title
derive_var_bcvacritxfl() and update vginettes/templates that use itderive_var_bcvacritxfl() and update vignettes/templates that use it
steventing12
added a commit
that referenced
this issue
Oct 21, 2024
…placing look-up table with derive_vars_merged() feat: #247 Used call_derivation with derive_vars_crit_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
|
Used call_derivation with derive_vars_crit_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl() |
|
Can you please make a pull request with your proposed changes? That way I can review code/changes and propose amendments. |
This was referenced Oct 22, 2024
14 tasks
manciniedoardo
added a commit
that referenced
this issue
Nov 14, 2024
manciniedoardo
added a commit
that referenced
this issue
Nov 19, 2024
…eplacing look-up table with derive_vars_merged() (#256) * feat: #244 Used derive_vars_cat() to derive AVALCA1N and AVALCAT1, replacing look-up table with derive_vars_merged() feat: #247 Used call_derivation with derive_vars_crit_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl() * Closes #244 Used derive_vars_cat() to derive AVALCA1N and AVALCAT1, replacing look-up table with derive_vars_merged() * Closes #244 Used derive_vars_cat() to derive AVALCA1N and AVALCAT1, replacing look-up table with derive_vars_merged() * Closes 244 Updating admiralophtha documentation * Closes #244 Update header to include documentation on using derive_vars_merged() in adbcva_crtflag dataframe with derive_vars_cat() to derive AVALCA1N and AVALCAT1 in ADBCVA template * Closes #244 Used derive_vars_cat() to derive AVALCA1N and AVALCAT1, replacing look-up table with derive_vars_merged() * Closes #244 Add authorship * Closes #244 Added derive_vars_cat() used in ADBCVA template * Closes 244 Add authorship * Closes 244 Add derive_vars_cat used in ADBCVA template * Closes 244 Added email * Closes 244 Added email * #244 try adding cli to imports to fix failing checks * Closes 244 Added get_admiral_option to admiral package * Closes 244 Used `derive_vars_cat` to derive AVALCA1N and AVALCAT1, replacing look-up table with `derive_vars_merged` * Update NEWS.md Co-authored-by: Edoardo Mancini <[email protected]> * Update vignettes/adbcva.Rmd Co-authored-by: Edoardo Mancini <[email protected]> * Update vignettes/adbcva.Rmd Co-authored-by: Edoardo Mancini <[email protected]> * Update vignettes/adbcva.Rmd Co-authored-by: Edoardo Mancini <[email protected]> * Closes 244 Updated under admiralophtha 1.1.0.9007 on changes to ADBCVA template to use `admiral::derive_vars_cat()` to derive `AVALCA1N` and `AVALCAT1` * Closes 244 Updated for documentation under admiralophtha 1.1.0.9007 for use of new function `admiral::derive_vars_cat()` to derive `AVALCA1N` and `AVALCAT1` in ADBCVA template * Update NEWS.md --------- Co-authored-by: Edoardo Mancini <[email protected]> Co-authored-by: Edoardo Mancini <[email protected]>
steventing12
added a commit
that referenced
this issue
Nov 22, 2024
…flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
steventing12
added a commit
that referenced
this issue
Nov 22, 2024
…it_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background Information
With the advent of admiral::derive_vars_crit_flag() there is less of a need for
admiralophtha::derive_var_bcvacrtixfl(). The latter should be superseded, in line with the {admiral} family's policy to not make many breaking changes post 1.0 releases.Definition of Done
derive_var_bcvacritxfl()superseded. See here for an example of a superseded function from {admiral}.derive_vars_crit_flag(), possibly in conjunction withcall_derivation().The text was updated successfully, but these errors were encountered: