Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #247: bcva crit flag update #253

Conversation

steventing12
Copy link
Collaborator

@steventing12 steventing12 commented Oct 22, 2024

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update).
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files.
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the [categorization of functions]
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately.
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiralophtha (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiralophtha site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package().
  • Run R CMD check locally and address all errors and warnings - devtools::check().
  • Link the issue so that it closes after successful merging.
  • Address all merge conflicts and resolve appropriately.
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

…placing look-up table with derive_vars_merged()

feat: #247 Used call_derivation with derive_vars_crit_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
@steventing12 steventing12 linked an issue Oct 22, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Oct 22, 2024

Code Coverage

Package Line Rate Health
admiralophtha 100%
Summary 100% (119 / 119)

@manciniedoardo
Copy link
Collaborator

@steventing12 please could you clean up this PR so it only includes the crterion flag updates for #247 and not the updates for #244 ? Otherwise it's hard to review. Thanks

@manciniedoardo manciniedoardo reopened this Nov 5, 2024
@manciniedoardo manciniedoardo changed the title feat: #244 Used derive_vars_cat() to derive AVALCA1N and AVALCAT1, re… Closes #247: bcva crit flag update Nov 5, 2024
steventing12 and others added 5 commits November 7, 2024 06:08
…eplacing look-up table with derive_vars_merged()
…flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
…it_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
Copy link
Collaborator

@manciniedoardo manciniedoardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @steventing12 - looks like a great start!

Along with the other comments, please could you also go ahead and supersede derive_vars_bcvacritxfl() - see here for an example and please try render the website to ensure the lifecycle:superseded badge renders properly.

NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
inst/templates/ad_adbcva.R Outdated Show resolved Hide resolved
vignettes/adbcva.Rmd Outdated Show resolved Hide resolved
inst/templates/ad_adbcva.R Show resolved Hide resolved
vignettes/adbcva.Rmd Outdated Show resolved Hide resolved
vignettes/adbcva.Rmd Show resolved Hide resolved
vignettes/adbcva.Rmd Outdated Show resolved Hide resolved
vignettes/adbcva.Rmd Outdated Show resolved Hide resolved
vignettes/adbcva.Rmd Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@manciniedoardo manciniedoardo self-requested a review December 5, 2024 10:20
@manciniedoardo manciniedoardo merged commit 65af193 into main Dec 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supersede derive_var_bcvacritxfl() and update vignettes/templates that use it
2 participants