-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #247: bcva crit flag update #253
Closes #247: bcva crit flag update #253
Conversation
…placing look-up table with derive_vars_merged() feat: #247 Used call_derivation with derive_vars_crit_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
@steventing12 please could you clean up this PR so it only includes the crterion flag updates for #247 and not the updates for #244 ? Otherwise it's hard to review. Thanks |
…eplacing look-up table with derive_vars_merged()
…flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
…it_flag() to generate CRITy conditions and CRITyFL flags, superseding derive_var_bcvacritxfl()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @steventing12 - looks like a great start!
Along with the other comments, please could you also go ahead and supersede derive_vars_bcvacritxfl()
- see here for an example and please try render the website to ensure the lifecycle:superseded badge renders properly.
…::derive_vars_crit_flag()`
…ate-vignettestemplates-that-use-it
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd files.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriately.NEWS.md
under the header# admiralophtha (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
.R CMD check
locally and address all errors and warnings -devtools::check()
.