-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #47 - Switch to admiraldev::assert_unit()
#52
Conversation
@AndersAskeland @manciniedoardo The updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just one minor comment from me. I tested the function and everything works as expected. Test coverage still good too. Thanks @yurovska!
@AndersAskeland feel free to review and merge when ready.
Co-authored-by: Edoardo Mancini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking good!
I have one thing that I think we should discuss before merging, which is how we should handle constant variables.
For instance, as the code is now, derive_param_waisthgt()
will set height as constant if we provide an argument for constant_by_vars
. I fear that this might be a bit confusing, both because the documentation says "By variables for when Height is constant", and that we don't specifically state we want a constant. I actually think we should have an additional argument, where we more specifically set height as a constant. For instance, constant_height
. What are your thoughts on this @yurovska ?
@AndersAskeland Thanks for your comment. I personally don't find it confusing given that all other similar |
In that case, I agree we should keep it consistent with admiral! Great work @yurovska ! |
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral family codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral<ext> (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()