Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #51 Update admiral-lookup-book.csv by adding admiralpeds variables #53

Conversation

Fanny-Gautier
Copy link
Contributor

Added {admiralpeds} variables

@ddsjoberg
Copy link
Collaborator

Thanks @Fanny-Gautier !

Can you take a look at the CI/CD failures? Let me know if you need help.

Just to confirm, did you build the website and confirmed your additions are present in the listing?

@Fanny-Gautier
Copy link
Contributor Author

Thanks @Fanny-Gautier !

Can you take a look at the CI/CD failures? Let me know if you need help.

Just to confirm, did you build the website and confirmed your additions are present in the listing?

It is now done. Could you please confirm whether I should also update NEWS.md?

@ddsjoberg ddsjoberg self-requested a review September 13, 2024 14:17
@ddsjoberg
Copy link
Collaborator

closes #51

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you for adding @Fanny-Gautier !!!

@bms63
Copy link
Contributor

bms63 commented Sep 13, 2024

Be great announcement on slack channel about this update - @Fanny-Gautier can you post?

@ddsjoberg ddsjoberg merged commit ad22677 into pharmaverse:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants