-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding article with links to old website versions #2190
Conversation
Damn. This is so nice. Before we merge this in, we'll need to clean up the HTML pages a bit to remove the |
@cicdguy I used the base R pipe here which is available for R 4.1 and later. We don't ever run pkgdown workflow on older versions of R, right? |
Yes, we only run |
@cicdguy just to put this on your radar in case it's not already taken care of. When we use a package in a pkgdown article (not a vignette), we add the following to the DESCRIPTION file I am not sure if we are also performing this same check and installing these article dependencies into our images. |
@cicdguy this PR adds an article with links to older versions of the website
This is not ready for merging and is a Draft PR.
_pkgdown.yml
?Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()