-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: AUC start 0 (which also needs Feature: C0 imputation) #138
Open
Gero1999
wants to merge
45
commits into
main
Choose a base branch
from
bug/auc-start-0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt for non-c0 parameters
…d renamed (select_X)
…adjust reshape for it
Merge remote-tracking branch 'origin/main' into bug/auc-start-0 # Conflicts: # inst/shiny/tabs/nca.R # inst/shiny/tabs/outputs.R
7 tasks
js3110
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Some requests:
Fixes:
- App crashes if AUC rule sets are selected
- Slope selector not working- i tested an exclusion and the app crashed. Haven't tried selections.
- Data table in Data selection tab is not sorted- needs to be sorted by USUBJID for better visualisation.
Enhancements:
- It would be good if the user can see an updated data table after the imputations, so they know what the data being used looks like. If this is too complex then maybe you can add an explanation of what the imputation is doing. But it would be good if they can see what data is being created.
- Some clarification/relabelling is required in terms of what the imputation does. 'C0 missing' is not always accurate, for example if the predose value is present in the data set but ATime is <0, it gets excluded, but its not technically missing. Some more clarification on this would be good for the user so they know that imputation is also for predose samples.
- Predose samples/ duplicates are not being included. Need to figure out a way to ensure they are- by creating duplicates manually or making sure PKNCA includes them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2 #60
Description
After running NCA, AUC calculations always consider the discrete start (start at where first concentration sample was collected). This can indeed alter slightly the real values of the AUC. This is a consequence of 2 problems:
Change description.
Definition of Done
C0 imputation option for the user specified in Setup > Data Selection
How to test
if
C0 exists
~C0=C0
if
DOSNO=1 & IV bolus (ADOSEDUR=0, ROUTE=intravascular)
~C0=0
if
DOSNO>1 & not IV bolus
~C0=predose
if
IV bolus and monoexponential data
~logslope
if
IV bolus and not monoexponential data
~C0=C1
Contributor checklist
Notes to reviewer
Anything that the reviewer should know before tacking the pull request?