Wrap node name in \tikz@pp@name when passed to pgf gd
#1119
Conversation
when tikz calls `\pgfgdedge`. Signed-off-by: muzimuzhi <[email protected]>
Signed-off-by: muzimuzhi <[email protected]>
The gd test set only runs on LuaTeX. `pgfgd-debug.lua` adds debugging code to `InterfaceToDisplay` functions which helps in checking tests based on states of display layer (Lua), rather than box content. Signed-off-by: muzimuzhi <[email protected]>
muzimuzhi
force-pushed
the
gd-name-prefix
branch
from
6ad9b59 to
dd89951
Compare
Signed-off-by: muzimuzhi <[email protected]>
|
Signed-off-by: Henri Menke <[email protected]>
Signed-off-by: Henri Menke <[email protected]>
|
Sorry, now I broke the tests. I'll look in the evening at home why that happens. |
Signed-off-by: Henri Menke <[email protected]>
| \catcode`\@=11 % \makeatletter | ||
|
|
||
| % this macro should be used _after_ graphdrawing library is loaded | ||
| \def\pgfgdBeforeBeginDocument{ |
There was a problem hiding this comment.
Now the test fails with
pgfgd-debug.lua:1: attempt to index a nil value (global 'pgf')
because when pgfgd-debug.lua is read in, the whole pgf is not loaded yet. This explains why the \pgfgdBeforeBeginDocument was introduced (and used after package loading and just before \begin{document}). For latex format only, \AtBeginDocument suffices but I more or less want(ed) a portable solution (not a strong opinion).
This extends pgf-tikz#1114, commit 2bff7c6 Signed-off-by: muzimuzhi <[email protected]>
- Load `pgfgd-test.lua` after gd lib. - Update test file (no prefix, no ending period). Signed-off-by: muzimuzhi <[email protected]>
|
Now "Test suite" is successful. "Check commits" still fails because of b65622a I made on webpage to resolve merge conflicts. A reminder: Now Oh this is already merged, so any "refactoring welcome" words is less useable. |
Motivation for this change
This PR consists of several parts, all
gdrelated:name prefix#1087gdwhich only runs on LuaTeX and may overlap with (final development of) Generate testsuite from pgfmanual #1116gdTo me, checking internal states and more human-readable generated log lines (here
.tlg) is preferable to seeing lengthy box content, so I introduce thepgfgd-debug.luawhich adds debugging code to Lua functions inInterfaceToDisplay.Todo or possible improvements:
\tikz@pp@name{<node name>}before being passed to macros. Again a call for pgf's\exp_args:Nxand\exp_args:Nxx.pgfgd-regression-test.tex, how to inputpgf-regression-test.texwhich resides insupportsub-directory of another test set?pgfgd-debug.lua. Can be achieved with some higher-order functions written in Lua, is it?Fixes #1087
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: