Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating implementation vroom #56

Merged
merged 13 commits into from
Aug 19, 2024
Merged

Separating implementation vroom #56

merged 13 commits into from
Aug 19, 2024

Conversation

cvvergara
Copy link
Member

Changes proposed in this pull request:

  • Separated implementation from header
  • Substitute call to one liner function with the line
  • Remove unused code
  • Documenting only public functions

@pgRouting/admins

@cvvergara cvvergara added enhancement New feature or request vroom labels Aug 11, 2024
@cvvergara cvvergara added this to the Release 0.4.2 milestone Aug 11, 2024
@cvvergara cvvergara requested review from krashish8 and robe2 August 11, 2024 01:48
krashish8
krashish8 approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this!

@krashish8
Copy link
Member

Check Documentation is failing, but I'll leave it upto you - we can merge this.

@cvvergara
Copy link
Member Author

Yes the doxygen is failing since the update on the last PR, will fix soon

@cvvergara cvvergara merged commit 105e049 into pgRouting:main Aug 19, 2024
6 of 8 checks passed
@cvvergara cvvergara deleted the separating-implementation-vroom branch August 19, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krashish8 krashish8 krashish8 approved these changes

@robe2 robe2 Awaiting requested review from robe2

Assignees
No one assigned
Labels
enhancement New feature or request vroom
Projects
None yet
Milestone
Release 0.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@cvvergara @krashish8